Compilation of Confluence Launch Bug Fixes

2/23/2022

Re-posted from Discord

As Hunter mentioned in Discord, after deploying L2 stake claiming support for delegators in the explorer earlier today, the core team discovered a small bug with the contract stake claiming logic. The bug could cause delegators that claim their stake on L2 to incorrectly be credited with some extra LPT rewards and ETH fees. Based on an investigation, we observed a handful of delegators accounts with some extra LPT rewards and ETH fees affected by this bug after claiming their stake on L2, but the overall amount was relatively small. This bug was fixed by the addition of a few lines of code in the BondingManager to ensure that earnings are correctly credited to a delegator account during stake claiming. At no point were user funds at risk, protocol funds remained accessible (even though some extra LPT rewards and ETH fees were incorrectly credited to a few accounts the amount was small and the Minter contract which holds protocol funds had plenty to cover that amount due to having some excess funds from the past) and a fix for the bug has been deployed.

The deployment of this bug fix is a part of the governance failsafes procedure described in [1]. While this bug did not cause user funds to be at risk of direct theft, it did represent the potential incorrect crediting of LPT rewards and ETH fees to certain accounts (over the amount the account was actually entitled to based on protocol rules) which ran counter to the expectations set by the LIP-73 specification [3]. With this in mind, the core team moved forward with a fix swiftly to resolve this issue for the community as soon as possible.

[1] Statement on the Governance Failsafes
[2] LIPs/LIP-73.md at master · livepeer/LIPs · GitHub

1 Like